-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default values using Pandas assign in design_matrix #8949
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8949 +/- ##
==========================================
+ Coverage 90.87% 90.88% +0.01%
==========================================
Files 352 352
Lines 21712 21710 -2
==========================================
+ Hits 19730 19731 +1
+ Misses 1982 1979 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/ert/config/design_matrix.py
Outdated
|
||
Returns a dict of default values | ||
Returns a dict of usable default values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the "usable" :)
383f774
to
fe5cc7e
Compare
return { | ||
row[0]: convert_to_numeric(row[1]) | ||
for _, row in default_df.iterrows() | ||
if row[0] not in existing_parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we write a test for this?
Resolve Pandas performance warning
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable